Skip to content

ITS: simplify constants + mathutils#14383

Merged
mconcas merged 2 commits intoAliceO2Group:devfrom
f3sch:its/pr7
Jun 11, 2025
Merged

ITS: simplify constants + mathutils#14383
mconcas merged 2 commits intoAliceO2Group:devfrom
f3sch:its/pr7

Conversation

@f3sch
Copy link
Collaborator

@f3sch f3sch commented Jun 10, 2025 •
edited
Loading

removes custom definitions of constants in favour of o2-wide ones.
also tries to simplify some math expressions.

@f3sch
ITS: simplify constants + mathutils
31ac10a 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@f3sch f3sch mentioned this pull request Jun 10, 2025
Merged
@alibuild
Copy link
Collaborator

alibuild commented Jun 10, 2025

Error while checking build/O2/fullCI_slc9 for 31ac10a at 2025-06-10 16:23:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14383-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:811:114: error: 'o2::its::constants::math' has not been declared
ninja: build stopped: subcommand failed.

Full log here.

mpuccio
mpuccio reviewed Jun 10, 2025
View reviewed changes
Copy link
Contributor

@mpuccio mpuccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, maybe there is only one small thing that was not really protected before but we could do better now.

@f3sch
ITS: mathutils protect against degeneracy
5d3f3f1 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@alibuild
Copy link
Collaborator

alibuild commented Jun 10, 2025

Error while checking build/O2/fullCI_slc9 for 5d3f3f1 at 2025-06-11 00:00:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14383-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:811:114: error: 'o2::its::constants::math' has not been declared
ninja: build stopped: subcommand failed.

Full log here.

@f3sch
Copy link
Collaborator Author

f3sch commented Jun 11, 2025

@mconcas @fprino I think this is ready to go if you approve

@mconcas mconcas merged commit 418a85f into AliceO2Group:dev Jun 11, 2025
13 of 14 checks passed
@f3sch f3sch deleted the its/pr7 branch June 11, 2025 07:32
mhemmer-cern pushed a commit to mhemmer-cern/AliceO2 that referenced this pull request Sep 9, 2025
@f3sch @mhemmer-cern
ITS: simplify constants + mathutils (AliceO2Group#14383)
bcadad0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fprino fprino fprino approved these changes

@mconcas mconcas Awaiting requested review from mconcas mconcas is a code owner

@shahor02 shahor02 Awaiting requested review from shahor02 shahor02 is a code owner

+1 more reviewer

@mpuccio mpuccio mpuccio left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@f3sch @alibuild @mpuccio @fprino @mconcas